skip AddReplicaKey if it is specified in config.Config.DiscoveryIgnoreReplicaHostnameFilters #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomi-noach
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @shlomi-noach.
As I understand, there is a special parameter in config DiscoveryIgnoreReplicaHostnameFilters, which is used especially to skip adding some replicas to Orchestrator (like different binlog dump routines). Right now, although replica is not added, it is still mentioned in slave_hosts field in database_instance table in Orchestrator DB, so API endpoints like /cluster/ still return such replicas in Json responses and it confuses all other services, which may rely on this data.
This PR prevents such situations, as all hosts specified in DiscoveryIgnoreReplicaHostnameFilters wouldn't be added to Orchestrator DB.