Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #116: precheck() honours -b #123

Merged
merged 1 commit into from
Apr 3, 2017

Conversation

samveen
Copy link
Contributor

@samveen samveen commented Mar 29, 2017

Fix Issue #116

The precheck() function in build.sh does not honor the -b option while checking prerequisites.

Related issue: #116

Description

The precheck() function in build.sh does not honor the -b option while checking for prerequisites. This pull request augments precheck() with checks against the build_only flag.

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@samveen
Copy link
Contributor Author

samveen commented Apr 3, 2017

@shlomi-noach What's required for the orchestrator-build-deploy-tarball check?

@shlomi-noach
Copy link
Collaborator

@samveen this is an internal CI that runs the same tests as the public TravisCI.

@shlomi-noach shlomi-noach merged commit cdba462 into openark:master Apr 3, 2017
@samveen samveen deleted the fix_116 branch April 4, 2017 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants