Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Orchestrator Favicon #1240

Merged
merged 2 commits into from Oct 12, 2020
Merged

Fix Orchestrator Favicon #1240

merged 2 commits into from Oct 12, 2020

Conversation

ushuz
Copy link
Contributor

@ushuz ushuz commented Sep 17, 2020

I added a color-inverted orchestrator logo as favicon, as the original light grey one doesn't look good as a favicon.

image

Close #444

@yakirgb
Copy link

yakirgb commented Sep 17, 2020

Nice

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated thank you!

@ushuz
Copy link
Contributor Author

ushuz commented Oct 12, 2020

@shlomi-noach Hi, it seems that this PR is not properly merged. Instead, the master branch was merged into this PR.

@shlomi-noach
Copy link
Collaborator

Right. I merged master into this branch to get it up to date, but never merged back. Meeting now. Thanks again

@shlomi-noach shlomi-noach merged commit 2f0228d into openark:master Oct 12, 2020
@ushuz ushuz deleted the favicon branch October 12, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favicon not loading
3 participants