Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for topology-tags command #1269

Conversation

nickdelnano
Copy link
Contributor

@nickdelnano nickdelnano commented Nov 17, 2020

related issue: #1268

Description

docs only change to add docs for the topology-tags command. I put the changed file into a markdown editor to confirm the styling.

  • contributed code is using same conventions as original code

Please make sure the PR passes CI tests. For your information, CI tests the following:

  • code is formatted via gofmt (please avoid goimports)
  • code passes compilation
  • code passes unit tests
  • code passes integration tests with MySQL backend
  • code passes integration tests with SQLite backend
  • There are no orphaned docs/ pages (there's some link in the docs to point to any page)
  • upgrade from previous version (master branch) is successful

👍

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@shlomi-noach shlomi-noach merged commit e305ad0 into openark:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants