Adjust the discovery uri logging to show the full dsn used (less pass… #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…word) This is helpful for debugging to be sure that the uri used is what you expect.
shlomi-noach
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few changes to show the full dsn used to talk to the MySQL driver. This helps debugging and what gets logged doesn't actually match what is passed to the driver which can be confusing.
Try to ensure that no passwords are logged, and if for some reason we can't match the dsn properly provide a synthetic dsn to provide information about the values we are using instead.
There are some tests to see that in various cases the process works correctly.
gofmt(please avoidgoimports)