Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-zero exit code for redeploy-internal-db #624

Merged
merged 3 commits into from
Oct 7, 2018

Conversation

bbuchalter
Copy link
Contributor

Closes #609

This ensures we get the expected non-zero exit code and print the
integration test log files which should contain the error messages.

Closes openark#609

This ensures we get the expected non-zero exit code and print the
integration test log files which should contain the error messages.
@bbuchalter bbuchalter force-pushed the fail_on_db_setup_2 branch 2 times, most recently from ebf7bb1 to 489d1ad Compare September 18, 2018 23:01
Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution!

@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=concertmaster October 7, 2018 05:15 Inactive
@shlomi-noach
Copy link
Collaborator

shlomi-noach commented Oct 7, 2018

deploys well

@shlomi-noach shlomi-noach merged commit 9b55a34 into openark:master Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants