Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the DiscoveryIgnoreReplicaHostnameFilters in the sample configuration. #815

Merged
merged 2 commits into from Mar 2, 2019

Conversation

jfg956
Copy link

@jfg956 jfg956 commented Feb 25, 2019

Add the DiscoveryIgnoreReplicaHostnameFilters in the sample configuration.

A Pull Request should be associated with an Issue.

#814

Description

Add the DiscoveryIgnoreReplicaHostnameFilters in the sample configuration.

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfg956 thank you! It's noteworthy that the value is actually a regular expression. A fixed hostname would work, but so will .*[.]datacenter3[.]example[.]com. Perhaps we should also provide a regexp as example?

@jfg956
Copy link
Author

jfg956 commented Mar 1, 2019

@shlomi-noach: I made explicit that DiscoveryIgnoreReplicaHostnameFilters can be a regexp.
Hopefully, this will do. Cheers, JFG

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@shlomi-noach shlomi-noach self-assigned this Mar 2, 2019
@shlomi-noach shlomi-noach merged commit 792f42d into openark:master Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants