Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify bulk-promotion-rules api call to return the promotion rule expiry timestamp #843

Merged
merged 3 commits into from Mar 24, 2019

Conversation

sjmudd
Copy link
Collaborator

@sjmudd sjmudd commented Mar 19, 2019

Description

See: #842 bulk promotion rule information does not include expiry information.

This PR [briefly explain what is does]

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code is built via ./build.sh

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=concertmaster March 19, 2019 11:04 Inactive
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=concertmaster March 19, 2019 12:25 Inactive
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=concertmaster March 24, 2019 07:05 Inactive
@shlomi-noach shlomi-noach merged commit 2c818cb into openark:master Mar 24, 2019
@sjmudd sjmudd deleted the smudd/promotion_rule_expiry branch December 25, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants