Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQLConnectTimeoutSeconds option in sample conf files. #860

Merged
merged 1 commit into from Apr 10, 2019
Merged

Add MySQLConnectTimeoutSeconds option in sample conf files. #860

merged 1 commit into from Apr 10, 2019

Conversation

jfg956
Copy link

@jfg956 jfg956 commented Apr 10, 2019

From issue 823, MySQLConnectTimeoutSeconds was in:

  • ./docs/configuration-sample.md
  • ./conf/orchestrator-sample.conf.json
    but not in:
  • conf/orchestrator-sample-sqlite.conf.json
  • conf/orchestrator-simple.conf.json

A Pull Request should be associated with an Issue.

Related issue: #823

Description

This PR add MySQLConnectTimeoutSeconds option in sample conf files.

From issue 823, MySQLConnectTimeoutSeconds was in:
- ./docs/configuration-sample.md
- ./conf/orchestrator-sample.conf.json
but not in:
- conf/orchestrator-sample-sqlite.conf.json
- conf/orchestrator-simple.conf.json
Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@shlomi-noach shlomi-noach merged commit 4c393e2 into openark:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants