Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DateTimeInput] Full minute/hour #3280

Closed
GhostofGeeeee opened this issue Mar 14, 2024 · 2 comments
Closed

[DateTimeInput] Full minute/hour #3280

GhostofGeeeee opened this issue Mar 14, 2024 · 2 comments
Labels

Comments

@GhostofGeeeee
Copy link
Contributor

I have a problem.
I initialize InstantRecordingEndTime with a time and 35 seconds deviation to the full minute.
If I change the time, I get the new displayed time +35 seconds. But I should get the full minute, because seconds are not displayed.
Except I do not make any changes, then it would be good to keep the 35 seconds.

Another ask!

class DateTime(Setup):
	def __init__(self, session, setupSection, default, smallStep=60):

Why "smallStep=60"? Then bigStep=3600 too!(def __init__(self, session, setupSection, default, smallStep=60, bigStep=3600):)

@IanSav
Copy link
Contributor

IanSav commented May 8, 2024

I am not sure that this is a bug. Most, if not all, time values in Enigma2 related to recordings do not have second values. If you want seconds displayed here then how far will this go? Is all of Enigma to be rewritten to support second calculations? Are all skins to be modified to support second displays.

A decision to make such changes across Enigma is not for me to decide. If you are missing the end of the recording by those 35 seconds then add a minute to the timer.

@jbleyel
Copy link
Contributor

jbleyel commented May 9, 2024

Another ask!

class DateTime(Setup):
	def __init__(self, session, setupSection, default, smallStep=60):

Why "smallStep=60"? Then bigStep=3600 too!(def __init__(self, session, setupSection, default, smallStep=60, bigStep=3600):)

@GhostofGeeeee : Can you please explain more. What's the issue of the steps?

@jbleyel jbleyel closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants