Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timezones.py] Multiple fixes #1570

Merged
merged 1 commit into from Mar 18, 2020
Merged

[Timezones.py] Multiple fixes #1570

merged 1 commit into from Mar 18, 2020

Conversation

IanSav
Copy link
Contributor

@IanSav IanSav commented Mar 18, 2020

  • Fix initialisation in "Classic" mode.
  • Fix "posix" and "right" zoneinfo files not being properly suppressed.
  • Fix the value of the "TZ" shell variable.
  • Fix logging messages referring to "Directories".

- Fix initialisation in "Classic" mode.
- Fix "posix" and "right" zoneinfo files not being properly suppressed.
- Fix the value of the "TZ" shell variable.
- Fix logging messages referring to "Directories".
@nickersk nickersk merged commit 6c741a2 into openatv:6.4 Mar 18, 2020
@IanSav IanSav deleted the patch-1 branch March 18, 2020 15:37
@Makumbo
Copy link
Contributor

Makumbo commented Mar 19, 2020

"Zeitzonengebiet" ist kein 'richtiges' Wort ;)
Es ist "doppelt gemoppelt"; eigentlich heißt es immer "Zeitzone", denn die "Zone" ist ja auch schon ein "Gebiet".
Und auch im englischen sollte es wohl eher "time zone" als "Timezone area" heißen.
"Your timezone in the area"? Eher "Your time zone", oder?

Shouldn't it be only "Time zone" instead of "Timezone area" because a 'zone' is also an 'area'?
And "Setup your timezone" instead of "Setup your timezone area"?
"Your timezone in the area"? Hmmm. Shouldn't it be "Your timezone" or "Your time zone"?
I'm confused.
Excuse my english.
Gruß - Greetings - Makumbo

@IanSav
Copy link
Contributor Author

IanSav commented Mar 19, 2020

How do you feel about these versions of the test:

Time zone area / region

Select your time zone area or region.

Time zone

Select the time zone within the area or region.

@Makumbo
Copy link
Contributor

Makumbo commented Mar 19, 2020

EDIT: New text: Your suggestions are OK.

But in german it should be:
Not "Ihre Zeitzone in Ihrem Gebiet." but "Wählen Sie die Zeitzone in Ihrem Gebiet."
Gruß - Makumbo

@IanSav
Copy link
Contributor Author

IanSav commented Mar 19, 2020

I will make the changes in the code. The German will be up to the translators. ;)

@IanSav
Copy link
Contributor Author

IanSav commented Mar 19, 2020

Done!

Pull Request #1572

@Makumbo
Copy link
Contributor

Makumbo commented Mar 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants