Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track posts to Slack in new table. Fixes #15. #16

Merged
merged 4 commits into from
Sep 6, 2017
Merged

Track posts to Slack in new table. Fixes #15. #16

merged 4 commits into from
Sep 6, 2017

Conversation

auxesis
Copy link
Contributor

@auxesis auxesis commented Sep 5, 2017 •
edited
Loading

This PR:

  • Changes the scraper to use a new table for recording runs called posts.
  • Adds logic to backfill data into the new table on first load.

Fixes #15.

@equivalentideas equivalentideas merged commit 347e7d5 into master Sep 6, 2017
@equivalentideas
Copy link
Collaborator

Looks good to me @auxesis 👍 Nice clear tests ✨

@auxesis auxesis mentioned this pull request Sep 6, 2017
Merged
equivalentideas added a commit that referenced this pull request Sep 7, 2017
@equivalentideas
Remove one-off data fixup methods
95a3c7b 
This was run once to fix some data that got messed up when we updated
the schema in #16

Read about the background here #17
@equivalentideas equivalentideas mentioned this pull request Sep 7, 2017
Merged
@auxesis auxesis mentioned this pull request Sep 7, 2017
Closed
@auxesis auxesis deleted the fix-sqlite-schema-spike-2 branch September 9, 2017 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equivalentideas equivalentideas Awaiting requested review from equivalentideas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@auxesis @equivalentideas