-
-
Notifications
You must be signed in to change notification settings - Fork 404
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
c195713
commit 4947447
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4947447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0a2 and (a1) aren't numbers. This versioning scheme breaks the OB_VERSION_CHECK macro (
error: user-defined literal in preprocessor expression
). If you really want an 'a' in there you could make it hexideciaml (0xa2). Of course, all of these will generate version numbers that are larger than the final release (3.0.0).4947447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, but as this is a standard versioning scheme, this is presumably a solved problem if we look around.
4947447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably they aren't trying to cast the full version string to an integer? I would suggest changing to 2.99.0xa2
You can't build any software that uses OB_VERSION as it is now.
4947447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agreed with @dkoes - next release should be from 2.99.*
4947447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4947447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So call 2.99.0xa3 "3.0.a3" in the package.json. But I want to be able to compile against master without having to first edit the version.
4947447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there's a difference between the OB_VERSION_CHECK header and the external name for the code.
Even if we change the macro, there are a variety of codes that mis-interpret alpha/beta designations. I remember this painfully (thus 1.99, 1.100, etc.)
4947447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, as you wish. But let's revisit this for OB 4.0. :-)