New functionality CIF. New Function in OBPairTemplate. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2) New Function in OBPairTemplate GetGenericValueDef(const ValueT &def_val). Return specified default value if the data is not exist.
|
For some reason, this wasn't closed, but the change was merged. Thanks! |
|
Besides the assert, please re-merge with master to resolve the minor conflicts, and I'll be happy to merge this! Thanks. |
Conflicts: src/formats/cifformat.cpp
|
Ready! |
ghutchis
added a commit
that referenced
this pull request
Dec 6, 2013
Read charges from CIF. New Function in OBPairTemplate to give default parameter.
This was referenced Feb 22, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compatibility with old GLIBC libraries.
Read charges from cif file and add it to special OBPair.
New Function in OBPairTemplate GetGenericValueDef(const ValueT &def_val).
Return specified default value if the data is not exist.