Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patched to build on NetBSD #2093

Merged
merged 2 commits into from Nov 24, 2019
Merged

patched to build on NetBSD #2093

merged 2 commits into from Nov 24, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 23, 2019

See issue #2092

@ghost ghost mentioned this pull request Nov 23, 2019
Copy link
Member

@ghutchis ghutchis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request - much easier to handle. But this doesn't build because of the un-matched { } braces.

file(GLOB man_1 *.1)
install(FILES ${man_1} DESTINATION share/man/man1)
install(FILES ${man_1} DESTINATION ${CMAKE_INSTALL_MANDIR]/man/man1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need { } or this fails.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ghost
Copy link
Author

ghost commented Nov 23, 2019

Sorry about that :(
I'm rather new to all this...
Is it correct now? I've corrected it on my repo.

@ghost ghost closed this Nov 23, 2019
@ghost ghost reopened this Nov 23, 2019
@ghutchis ghutchis merged commit 59dff1b into openbabel:master Nov 24, 2019
@baoilleach
Copy link
Member

Just a note to say that I'm putting together the release notes for 3.0.1. I usually include the github name and people's real names. I don't have yours - contact me asap (my username at gmail.com) if you wish me to include it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants