Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transformation parser case insensitive #255

Merged
merged 1 commit into from
Feb 3, 2016

Conversation

afonari
Copy link
Contributor

@afonari afonari commented Feb 3, 2016

This needed in the cases like:

loop_
_symmetry_equiv_pos_site_id
_symmetry_equiv_pos_as_xyz
1 +X,+Y,+Z
2 -X,+Y,+Z
3 +X,1/2-Y,1/2+Z
4 -X,1/2-Y,1/2+Z
5 -X,-Y,-Z
6 +X,-Y,-Z
7 -X,1/2+Y,1/2-Z
8 +X,1/2+Y,1/2-Z

This needed in the cases like:

loop_
_symmetry_equiv_pos_site_id
_symmetry_equiv_pos_as_xyz
1 +X,+Y,+Z
2 -X,+Y,+Z
3 +X,1/2-Y,1/2+Z
4 -X,1/2-Y,1/2+Z
5 -X,-Y,-Z
6 +X,-Y,-Z
7 -X,1/2+Y,1/2-Z
8 +X,1/2+Y,1/2-Z
@ghutchis
Copy link
Member

ghutchis commented Feb 3, 2016

This is an easy one. Thanks!

ghutchis added a commit that referenced this pull request Feb 3, 2016
Make transformation parser case insensitive
@ghutchis ghutchis merged commit 2d1730e into openbabel:master Feb 3, 2016
@afonari
Copy link
Contributor Author

afonari commented Feb 3, 2016

Thanks for the fast review and merge.

ghutchis added a commit that referenced this pull request Feb 12, 2016
Add unit tests for pull requests: #254 #255 #260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants