Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Vault with OpenBao #10

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Replace Vault with OpenBao #10

merged 1 commit into from
Dec 11, 2023

Conversation

jmls
Copy link
Contributor

@jmls jmls commented Dec 8, 2023

replaced a number of occurrences ( where it makes sense ) of Vault with OpenBao

@Scorpil
Copy link
Contributor

Scorpil commented Dec 9, 2023

LGTM @naphelps

@joewxboy
Copy link
Contributor

joewxboy commented Dec 9, 2023

@Scorpil and @jmls for some reason, the commits don't pass the DCO check.

The signoff doesn't work as a straight comment, so you can remove commit 592c323.
Try amending commit c67a9c2 with some variant of:

git commit --amend --signoff

@jmls
Replace Vault with OpenBao
2463e88 
replaced a number of occurrences ( where it makes sense ) of Vault with OpenBao

Signed-off-by: jmls <julian+github@dotr.com>
@joewxboy joewxboy linked an issue Dec 11, 2023 that may be closed by this pull request
Edit documentation to replace product references #6
Closed
@joewxboy joewxboy merged commit 03f094a into openbao:development Dec 11, 2023
8 of 9 checks passed
@joewxboy
Copy link
Contributor

Thanks, @jmls , merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joewxboy joewxboy joewxboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit documentation to replace product references
3 participants
@jmls @Scorpil @joewxboy