Part 15/n - Minor plugin related changes #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openapi.sh is used to generate the OpenAPI data; to function, it needs to know a list of all plugins supported by OpenBao in order to accurately map the dynamically generated APIs. Note that this does mean that OpenAPI-based data will differ based on the numbers and types of loaded plugins. Our OpenAPI generated clients will reflect that supported by the core OpenBao, but if we wish to generate additional APIs for external-but-supported plugins, we'll have to re-add them here and modify the script. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
This updates various tests that count the number of expected plugins, ensuring they match as a sanity check. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Command prediction was tested including some information of available plugins; since these have changed, the candidates for prediction also changed and thus this test was out of date. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Plugin response ordering depended on the name of the plugin; this was wrong with the initial rename from GitHub/Consul to AppRole and K/V. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
In forking OpenBao, we opted as part of openbao#53 to not include already deprecated plugins present in upstream. This saves us some maintenance burden as we won't have to have a temporary release with support and a later release doing the removal. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
App-Id, a deprecated and removed auth method, was expected to be present in certain test scenarios in the plugin list and elsewhere; remove it and rely on a plugin that still remains. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
minor-plugin-related-changes
branch
from
0bb5687
to
9e508c3
Compare
naphelps
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
Part of #68; broken up for reviewability.