Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete docs of removed plugins #116

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

JanMa
Copy link
Member

@JanMa JanMa commented Feb 3, 2024

This deletes documentation for the plugins which are no longer officially supported by OpenBao according to the plugin proposal

Copy link
Member

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the following additional docs need to go:

./content/docs/agent-and-proxy/autoauth/methods/{aws,alicloud}.mdx ## And more

I think there's also a few references here and there to removed stuff, e.g.:

content/api-docs/system/plugins-catalog.mdx:43:            "mssql-database-plugin",

(listing of plugins from an API response)

Hmm, this also doesn't build:

Please add these paths to the "../content/docs" nav data file, or remove the .mdx files. If you want the pages to exist but not be linked in the navigation, you can add a "hidden" property to the page object in the navigation structure.

[
  "commands/namespace"
]

(Edit: I guess this was an issue in #65)

But over all, this looks very good! Thanks @JanMa!

@JanMa
Copy link
Member Author

JanMa commented Feb 5, 2024

Thanks @cipherboy , seems like the docs are littered with examples for the AWS secret engine and some others we removed. I'm in the process of cleaning that up

@JanMa JanMa force-pushed the delete-old-docs branch 4 times, most recently from 20fce9f to e3f124f Compare February 7, 2024 00:14
Copy link
Member

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks @JanMa!

Signed-off-by: Jan Martens <jan@martens.eu.org>
@naphelps naphelps merged commit 59f129d into openbao:main Feb 9, 2024
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants