Remove patch for SHA-1 certificates #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
remove-sha1-patch
branch
from
c775c84
to
f48057d
Compare
JanMa
approved these changes
Feb 4, 2024
cipherboy
force-pushed
the
remove-sha1-patch
branch
from
f48057d
to
2a7400a
Compare
Vault < 1.12 supported a patch to allow certificates with SHA-1 hashes to continue to function after Go removed support in Go 1.18 (or, rather, gated it behind a feature flag). As our version number remains unclear, we'll want to remove this patch in case we choose a lower version number for our releases. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
remove-sha1-patch
branch
from
2a7400a
to
9e6b007
Compare
naphelps
approved these changes
Feb 9, 2024
|
Thank you @naphelps! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault < 1.12 supported a patch to allow certificates with SHA-1 hashes to continue to function after Go removed support in Go 1.18 (or, rather, gated it behind a feature flag).
As our version number remains unclear, we'll want to remove this patch in case we choose a lower version number for our releases.
Note: this will not affect users' abilities to manually override this according to Go's settings to do so; this only removes dead code that did so automatically on older versions.