Move to Go 1.22.0 #124
Merged
Move to Go 1.22.0 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Nah, this is a good point, the comment in |
cipherboy
force-pushed
the
bump-go-1.21.6
branch
from
0d145e7
to
1995d8b
Compare
Gabrielopesantos
approved these changes
Feb 8, 2024
cipherboy
force-pushed
the
bump-go-1.21.6
branch
3 times, most recently
from
5b321a5
to
7ccb64f
Compare
|
@naphelps I'm happy with this one based on more testing I've done locally. I've switched to it as my primary toolchain now. |
cipherboy
force-pushed
the
bump-go-1.21.6
branch
from
7ccb64f
to
6f24dd5
Compare
This moves from Go 1.20 to 1.22 to follow the latest toolchain release. Resolves: openbao#120 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Without this change, radius tests would fail with an error like:
> --- FAIL: TestBackend_acceptance (5.66s)
> panic: runtime error: slice bounds out of range [:16] with capacity 4 [recovered]
> panic: runtime error: slice bounds out of range [:16] with capacity 4
>
> goroutine 1608 [running]:
> testing.tRunner.func1.2({0x2a70260, 0xc001302168})
> /usr/local/go/src/testing/testing.go:1631 +0x24a
> testing.tRunner.func1()
> /usr/local/go/src/testing/testing.go:1634 +0x377
> panic({0x2a70260?, 0xc001302168?})
> /usr/local/go/src/runtime/panic.go:770 +0x132
> layeh.com/radius.NewUserPassword({0x2c6eb78, 0x4, 0x4}, {0xc000c6ca60, 0xa, 0x10}, {0xc0013015c9, 0x10, 0x10})
> /home/cipherboy/go/pkg/mod/layeh.com/radius@v0.0.0-20190322222518-890bc1058917/attribute.go:207 +0x525
> layeh.com/radius/rfc2865.UserPassword_SetString(0xc0013015c0, {0x2c6eb78?, 0x1?})
> /home/cipherboy/go/pkg/mod/layeh.com/radius@v0.0.0-20190322222518-890bc1058917/rfc2865/generated.go:248 +0x5c
> github.com/openbao/openbao/builtin/credential/radius.(*backend).RadiusLogin(0xc0009c8498, {0x34531d0, 0xc00132c1e0}, 0xc0013221c0, {0xc001302117, 0x4}, {0x2c6eb78, 0x4})
Notably, this was a few commits behind the latest master branch upstream
for layeh.com/radius: a subsequent commit fixed this. However, note that
the latest commit upstream (1006025) seems to have some discussion as to
correctness, so the previous commit has been chosen instead.
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
This occasionally fails with the following:
--- FAIL: TestAgent_Template_Basic (20.23s)
--- FAIL: TestAgent_Template_Basic/many_with_exit (10.02s)
agent_test.go:874: timed out waiting for templates to render, last error: expected (13) templates, got (12)
Usually this goes away when running the test individually (or the
only running the package's tests); however, when running multiple test
packages are part of `make test`, this test flakes.
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
force-pushed
the
bump-go-1.21.6
branch
from
6f24dd5
to
a768246
Compare
naphelps
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves from Go 1.20 to 1.21 to follow the latest toolchain release.
Resolves: #120