Remove Consul service registration #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMa
requested changes
Mar 3, 2024
There was a problem hiding this comment.
@cipherboy please also remove the relevant documentation if we're going to drop the feature
|
@JanMa ah yes, good reminder! |
cipherboy
force-pushed
the
remove-consul-service-registration
branch
from
604a43f
to
c740a31
Compare
JanMa
approved these changes
Mar 4, 2024
This removes the non-OSI licensed Consul service discovery integration, favoring the remaining Kubernetes discovery mechanism if one is required. In the event that other (especially non-OSI) mechanisms are desired, a plugin system could be added to implement this outside of the main binary. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
force-pushed
the
remove-consul-service-registration
branch
from
c740a31
to
7665e7d
Compare
naphelps
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the non-BUSL Consul service registration; the only remaining service registration is thus Kubernetes.