-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PKI: Remove references to managed keys and enterprise no-ops functions #169
PKI: Remove references to managed keys and enterprise no-ops functions #169
Conversation
675b33e
to
7e54c6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind doing an interactive rebase, it'd be nice to drop both 46b9d99c7d5a261d81e9fead18c11947f4e24df9 and 4ef68b486f9828055a69c8af9407b21ca22af2ff, so we don't remove-and-re-add in the same PR since it won't be squashed. :-)
Otherwise I think this looks good, thanks @Gabrielopesantos!!
c2d48fc
to
9b178ba
Compare
Sure, I couldn't find the objects (commits) you mentioned and rebased the branch with the main. Is that what you meant? EDIT: I also see the "Check changelog" failing, as expected, is that already being enforced and do I need to add a changelog file to the PR? |
@Gabrielopesantos Feel free to skip the CL, I'm considering this all part of the initial "fork" changeset. I don't have labeling permissions and Nathan has been ignoring it :-) Sorry, not sure how I gave you such bogus commits lol. I meant the first and the last ones:
|
0eafe99
to
b068be8
Compare
I did not see that change was introduced in the first commit. Addressed. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Gabrielopesantos!! Looks good to me :-) Want to try unified CRLs next?
b068be8
to
db1213d
Compare
@Gabrielopesantos As soon as you rebase this with updates, I will merge this one in. Thanks. |
db1213d
to
a196bc8
Compare
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
Signed-off-by: Gabriel Santos <gabrielopesantos97@gmail.com>
a196bc8
to
d08f3d6
Compare
Description
This PR is a follow-up to #142, it removes the
managed_key_util.go
file from PKI, with no-ops enterprise functions and all of these functions.Besides that, it also removes all references and usages of managed keys in the engine and SDK.
P.S: This PR has to be rebased once #142 is merged.