Add Shamir's to shared sdk/, fix titles in API & SDK READMEs #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMa
approved these changes
Mar 6, 2024
Gabrielopesantos
approved these changes
Mar 6, 2024
|
@Gabrielopesantos said:
Honestly, I don't recall! I recall it being discussed, and is used by external parties. Though, it doesn't appear on my favorite list... I suspect people (like the first) have pinned an old version of the library that could be imported and haven't upgraded since. My 2c... but I think we can reach out after we tag an SDK version (later) and see if they're interested in swapping out for ours. |
cipherboy
force-pushed
the
reorganize-apis-sdk
branch
from
bf4de2a
to
01e2171
Compare
This moves shamir's code into the public sdk/ space, encouraging the reuse of this component by other external libraries. Also fixes the titles of API and SDK READMEs. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
force-pushed
the
reorganize-apis-sdk
branch
from
01e2171
to
0e3bc49
Compare
naphelps
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves Shamir's to
sdk/, as it is a generally useful package for others. Additionally, we fix the titles of the API & SDK while we're here.