Fix OpenBao OIDC followed by Google OIDC not working on Android #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
This looks very useful, many thanks for the contribution @siepkes and @prajnamohan1!
I do not have an Android app handy to test with, but the code looks straightforward and makes sense to me.
This fixes the issue when having an Android app authenticate with the OpenBoa OIDC identity provider and having OpenBao in turn authenticate the user with Google OIDC the redirect back to the Android app from OpenBao doesn't work. So after logging in with Google you get correctly redirected to OpenBao but then OpenBAO doesn't redirect back to the app. Chrome (104) on Android would show the logo loading animation forever. This code was originally developed by @prajnamohan1 while working at Service Planet Rotterdam B.V.. I, Jasper Siepkes, in my capacity of IT Manager at Service Planet Rotterdam B.V. herby grant permission to use this code under the MPL-2.0 license. Resolves: openbao#184 Signed-off-by: Jasper Siepkes <siepkes@serviceplanet.nl>
siepkes
force-pushed
the
android_redirect_fix
branch
from
8d026db
to
7da1fcb
Compare
naphelps
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue when having an Android app authenticate with the OpenBoa OIDC identity provider and having OpenBao in turn authenticate the user with Google OIDC the redirect back to the Android app from OpenBao doesn't work. So after logging in with Google you get correctly redirected to OpenBao but then OpenBAO doesn't redirect back to the app. Chrome (104) on Android would show the logo loading animation forever.
This code was originally developed by @prajnamohan1 while working at Service Planet Rotterdam B.V.. I, Jasper Siepkes, in my capacity of IT Manager at Service Planet Rotterdam B.V. herby grant permission to use this code under the MPL-2.0 license.
Resolves: #184