Remove remaining permissions issues in pipelines #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naphelps
force-pushed
the
fix-pipeline-ci-permissions
branch
from
675ec16
to
6fd274f
Compare
cipherboy
force-pushed
the
fix-pipeline-ci-permissions
branch
from
6fd274f
to
8e551dd
Compare
This fixes a race condition in builtin/credential/kubernetes, where various tests which validated the mount's TLS configuration were performed without holding a lock over that data, potentially causing a race. Interestingly, the race detector would fail with invalid results when the horizon multiple was set too high, but only with race testing enabled. Disabling race testing with the higher horizon multiple didn't negatively affect results. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
This removes the remaining unused permissions from the test-go workflow, fixing testing upstream. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
fix-pipeline-ci-permissions
branch
from
8e551dd
to
c82abc9
Compare
Bumps [actions/cache](https://github.com/actions/cache) from 3.3.1 to 4.0.1. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@88522ab...ab5e6d0) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
fix-pipeline-ci-permissions
branch
from
a2b5d05
to
7fac0e3
Compare
This reverts commit 1d0b2dd. When accepting the commit from openbao#125, this causes failures in the pipeline like: > Error: Failed to CreateArtifact: Received non-retryable error: > Failed request: > (409) Conflict: an artifact with this name already > exists on the workflow run So likely we've fallen into the breaking change section of v3->v4 behavior. Some investigation will be needed to determine what to change to fix this issue. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
fix-pipeline-ci-permissions
branch
from
7fac0e3
to
fafdcf2
Compare
naphelps
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the remaining unused permissions from the test-go workflow, fixing testing upstream.
See https://github.com/openbao/openbao/actions/runs/8207302185/workflow for an example failing workflow.