Fixed issue PKI: Support explicit Basic Constraints isCA=False #81 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanGhita
force-pushed
the
issue_81_PKI_Basic_Constraints_NotCA
branch
from
8e89d79
to
997c641
Compare
|
Hi @naphelps, I think I'm done with the current PR (CI tests on going), could you have a look at it and merge it if no remark ? Thanks, |
|
@DanGhita Do you want to add a changelog entry? Thanks! |
cipherboy
reviewed
Mar 24, 2024
builtin/logical/pki/backend_test.go
Outdated
| t.Fatalf("expected a single cert, got %d", len(certs)) | ||
| } | ||
| cert = certs[0] | ||
| if math.Abs(float64(time.Now().Add(12*time.Hour).Unix()-cert.NotAfter.Unix())) < 10 { |
There was a problem hiding this comment.
IMHO, not worth validating this. :-)
builtin/logical/pki/ca_util.go
Outdated
| @@ -314,6 +315,7 @@ func buildSignVerbatimRole(data *framework.FieldData, role *roleEntry) *roleEntr | |||
| } | |||
| entry.NoStore = role.NoStore | |||
| entry.Issuer = role.Issuer | |||
| entry.BasicConstraintsValidForNonCA = role.BasicConstraintsValidForNonCA | |||
There was a problem hiding this comment.
Should this be added conditionally on whether the parameter was provided?
If so, I'd do:
if , ok := data.GetOk("basic_constraints_valid_for_non_ca"); !ok {
entry.BasicConstraintsValidForNonCA = role.BasicConstraintsValidForNonCA
}That way, if a role requires it, but the API call explicitly disables it, you respect that explicit disabling. My 2c.
|
Hi @naphelps, Alex approved the PR, I think it can me merged to the main. Thanks! |
…o#81 Signed-off-by: DanGhita <dan.ghita@viaccess-orca.com>
Signed-off-by: DanGhita <dan.ghita@viaccess-orca.com>
…rovided in the API call, it takes priority over the value set in the role. Signed-off-by: DanGhita <dan.ghita@viaccess-orca.com>
naphelps
force-pushed
the
issue_81_PKI_Basic_Constraints_NotCA
branch
from
5f34da1
to
491b677
Compare
naphelps
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When issuing certificates with /pki_int/sign-verbatim, if the initial CSR contains the extension basicConstraints=CA:FALSE, the issued certificate must include this extension.
Resolves #
#81
Target Release
1.14.7