Allow specifying key type during issuance #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
pki-any-key-type-issuance
branch
2 times, most recently
from
126a868
to
9acd8c5
Compare
naphelps
approved these changes
Mar 18, 2024
When a role explicitly allows any key type, certificates of any type or size can be issued via the pki/sign/:role endpoint. However, issuing with OpenBao-generated key material isn't possible as OpenBao doesn't know what key type to assign. Thus, introduce new key_type and key_bits parameters, letting callers opt-in to specific certificate types. Resolves: openbao#188 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
force-pushed
the
pki-any-key-type-issuance
branch
from
9acd8c5
to
1eb9a91
Compare
|
Never seen this flake before, it seems unrelated as it is in Core (unmodified): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a role explicitly allows any key type, certificates of any type or size can be issued via the
pki/sign/:roleendpoint. However, issuing with OpenBao-generated key material isn't possible as OpenBao doesn't know what key type to assign. Thus, introduce newkey_typeandkey_bitsparameters, letting callers opt-in to specific certificate types.Resolves: #188