Improvements to Shamir's implementation #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds several improvements to Shamir's implementation:
1. Use a CS-PRNG with a shuffling algorithm to permute X coordinates in
the range [1, 254], removing the need for a later +1 addition later.
2. Panic in the (unreachable) event that the polynomial is evaluated at
x == 0; this was already unreachable (and further explicit
improvements to shuffling have ensured it remains so), and as it is
in a private library function, panicing is an acceptable approach
rather than returning an error.
3. Annotate the inverse function to describe multiplications for
maintainability.
Resolves: openbao#182
Co-authored-by: @wavefnx
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
shamirs-improvements
branch
from
7203fff
to
e15e83e
Compare
naphelps
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds several improvements to Shamir's implementation:
Resolves: #182
Co-authored-by: @wavefnx