Add soft deletion of Transit keys #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
transit-soft-delete
branch
from
8590243
to
b2f35c7
Compare
naphelps
approved these changes
Mar 18, 2024
This adds soft deletion of Transit keys, allowing users to mark keys as deleted without impacting the ability to backup the key or affecting its availability to be restored (but preventing all other operations). This explicitly allows non-exportable keys to be more safely removed, first via soft deletion (to see if any workloads break and to generally prevent usage of the key) and then via permanent deletion. Resolves: openbao#88 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
When a RSA keypolicy is generated (and not merely imported), RSAPublicKey is set to nil, incorrectly preventing the wrapping of other keys with this policy. Fix this condition, allowing BYOK export with destination (wrapping) keys created inside the same Transit instance. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
force-pushed
the
transit-soft-delete
branch
from
b2f35c7
to
a8b03f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds soft deletion of Transit keys, allowing users to mark keys as
deleted without impacting the ability to backup the key or affecting its
availability to be restored (but preventing all other operations). This
explicitly allows non-exportable keys to be more safely removed, first
via soft deletion (to see if any workloads break and to generally
prevent usage of the key) and then via permanent deletion.
Resolves: #88
I also noticed a bug while adding this:
When a RSA keypolicy is generated (and not merely imported),
RSAPublicKeyis set tonil, incorrectly preventing the wrapping ofother keys with this policy. Fix this condition, allowing BYOK export
with destination (wrapping) keys created inside the same Transit
instance.