Allow customizing key export format in Transit #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
transit-public-key-formats
branch
from
d6ade22
to
d362e80
Compare
naphelps
approved these changes
Mar 18, 2024
Transit's export functionality didn't allow choosing the desired output key format and was largely inconsistent about typing. Symmetric keys (and ed25519!) were returned in raw (base64-encoded byte array) format, but RSA and EC keys were returned in their native container formats. This prevents easy interoperability as some tools will not read all of these formats easily; add "der" and "pem" forms for asymmetric keys, to allow native PKIX-typed exports (in typed SubjectPublicKeyInfo or PrivateKeyInfo containers). Resolves: openbao#86 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
force-pushed
the
transit-public-key-formats
branch
from
d362e80
to
c0f44d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transit's export functionality didn't allow choosing the desired output key format and was largely inconsistent about typing. Symmetric keys (and ed25519!) were returned in raw (base64-encoded byte array) format, but RSA and EC keys were returned in their native container formats. This prevents easy interoperability as some tools will not read all of these formats easily; add "der" and "pem" forms for asymmetric keys, to allow native PKIX-typed exports (in typed
SubjectPublicKeyInfoorPrivateKeyInfocontainers).Resolves: #86