Add global handling of -non-interactive #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
expand-non-interactive
branch
2 times, most recently
from
0ecb946
to
a2db9db
Compare
naphelps
approved these changes
Mar 18, 2024
naphelps
force-pushed
the
expand-non-interactive
branch
from
a2db9db
to
f243821
Compare
|
@naphelps looks like this one still fails tests, I'll address that when I get time later. Thought I had fixed that. |
cipherboy
force-pushed
the
expand-non-interactive
branch
from
f243821
to
ac5c5bb
Compare
|
@naphelps This should be fixed. Not sure why I added it to unseal, tbh, meant the test to be for |
This adds global handling of the -non-interactive flag introduced originally for non-interactive MFA support. Most commands with interactive use of stdin will either get an empty reader (presumably allowing it to err later) or explicitly err about not being passed input that would otherwise be requested via stdin (e.g., operator unseal or login). Resolves: openbao#220 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
force-pushed
the
expand-non-interactive
branch
from
ac5c5bb
to
dc6be36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds global handling of the
-non-interactiveflag introduced originally for non-interactive MFA support. Most commands with interactive use ofstdinwill either get an empty reader (presumably allowing it to err later) or explicitly err about not being passed input that would otherwise be requested via stdin (e.g.,operator unsealorlogin).Resolves: #220