Fix semgrep issues #222
Merged
Fix semgrep issues #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMa
approved these changes
Mar 19, 2024
While the contant WALRollbackMinAge is not user facing, we might as well use the parseutil variant for consistency. Additionally, switch the test suite's flag behavior (to exclude the long-running WAL test) to the opposite behavior as CI does not build with a shorter WALRollbackMinAge value. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
force-pushed
the
fix-semgrep-issues
branch
from
e697a59
to
6c09c5a
Compare
naphelps
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the failing semgrep issues, by updating the kubernetes plugin to use the preferred duration parsing logic and excluding tools/ folders from semgrep results.