Fix anchor generation in website partials #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
approved these changes
Mar 20, 2024
I've added some screenshots to the PR body to show the difference |
We use a custom plugin from upstream to include partials in our MDX docs which can also contain MDX syntax that needs to be evaluated. The inclusion needs to happen before the default docusaurus remark plugins run for them to be able to properly evaluate the contained MDX syntax. One example where this currently does not work is when we overwrite the generated anchors of a heading. Signed-off-by: Jan Martens <jan@martens.eu.org>
naphelps
approved these changes
Mar 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a custom plugin from upstream to include partials in our MDX docs
which can also contain MDX syntax that needs to be evaluated. The
inclusion needs to happen before the default docusaurus remark plugins
run for them to be able to properly evaluate the contained MDX syntax.
One example where this currently does not work is when we overwrite the
generated anchors of a heading.
Current status:
Fixed status:
