Issue-153: Adding a github workflow for handling releases. #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
reviewed
Mar 29, 2024
|
@cipherboy I think I got all of your in-lines. |
JanMa
requested changes
Mar 30, 2024
cipherboy
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
I don't see a reason to hold this up any further... I suspect the new layout of packages will break existing users expecting drop-in replacement. And I'd like to see the existing (now broken) build scripts removed in the future. But these are nitpicks to deal with later.
Signed-off-by: Nathan Phelps <naphelps@us.ibm.com>
Signed-off-by: Nathan Phelps <naphelps@us.ibm.com>
… a destination directoy path for openbao.service. Signed-off-by: Nathan Phelps <naphelps@us.ibm.com>
Signed-off-by: Nathan Phelps <naphelps@us.ibm.com>
…ries in the same directory structure as the existing Dockerfile. Signed-off-by: Nathan Phelps <naphelps@us.ibm.com>
…or bsd, solaris, wasm, and arch linux. Signed-off-by: Nathan Phelps <naphelps@us.ibm.com>
Signed-off-by: Nathan Phelps <naphelps@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #153
Changes: