-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename Vault to OpenBao in build files #45
Conversation
6bb86b6
to
3d96b7b
Compare
Signed-off-by: Alexander Sharov <kvendingoldo@yandex.ru>
3d96b7b
to
a839420
Compare
The files still have their Hashicorp copyright blocks.
I guess this also has to transform along with the filecontents. |
@Varjoissa HashiCorp still largely retains copyright of the original files, so this is expected. |
I understand what you mean and I agree to some extend. Since im not a guy who has experience with these legal matters, maybe this should be looked into. |
@Varjoissa I suggest to change a license header in a separate PR, after discussion. WDYT? |
@Varjoissa I've fixed your comment |
Signed-off-by: Alexander Sharov <kvendingoldo@yandex.ru>
c44d7f4
to
5955865
Compare
thread about license header is here: https://github.com/orgs/openbao/discussions/48 |
And for the record, for anyone reading this file in the future, we must ensure that we do NOT remove any legally-required attribution from these files. This would include any existing copyright notices. Those should not be removed or modified in any way, except possibly to fix the format of the SPDX header if there was a format error and as long as it does not change the contents in any way. But IANAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits :-) Thank you for this, @kvendingoldo!
# | ||
# For production derivatives of this container, you shoud add the IPC_LOCK | ||
# capability so that Vault can mlock memory. | ||
# capability so that OpenBao can mlock memory. | ||
COPY .release/docker/docker-entrypoint.sh /usr/local/bin/docker-entrypoint.sh | ||
ENTRYPOINT ["docker-entrypoint.sh"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT, docker-entrypoint.sh
isn't modified in this PR, so I don't think this will work. Are you interested in doing that? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit (sorry!) but then I think it looks good to me! Thank you @kvendingoldo!
RUN set -eux; \ | ||
apk add --no-cache ca-certificates libcap su-exec dumb-init tzdata | ||
|
||
COPY --from=builder /go/src/github.com/lf-edge/openbao/bin/vault /bin/vault | ||
COPY --from=builder /go/src/github.com/lf-edge/openbao/bin/bao /bin/bao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we've moved into the openbao/openbao
namespace, so this breaks:
$ make docker-dev
... output elided ...
[1/2] STEP 4/6: WORKDIR /go/src/github.com/openbao/openbao
... more output elided ...
==> Results:
total 128M
-rwxr-xr-x. 1 root root 128M Jan 29 15:07 bao
--> 81f44a0917fc
[2/2] STEP 1/11: FROM alpine:3.13
[2/2] STEP 2/11: RUN addgroup bao && adduser -S -G bao bao
--> 1c3994831238
[2/2] STEP 3/11: RUN set -eux; apk add --no-cache ca-certificates libcap su-exec dumb-init tzdata
+ apk add --no-cache ca-certificates libcap su-exec dumb-init tzdata
fetch https://dl-cdn.alpinelinux.org/alpine/v3.13/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.13/community/x86_64/APKINDEX.tar.gz
(1/5) Installing ca-certificates (20220614-r0)
(2/5) Installing dumb-init (1.2.5-r0)
(3/5) Installing libcap (2.46-r0)
(4/5) Installing su-exec (0.2-r1)
(5/5) Installing tzdata (2022f-r1)
Executing busybox-1.32.1-r9.trigger
Executing ca-certificates-20220614-r0.trigger
OK: 10 MiB in 19 packages
--> 2c9187cd7694
[2/2] STEP 4/11: COPY --from=builder /go/src/github.com/lf-edge/openbao/bin/bao /bin/bao
Error: building at STEP "COPY --from=builder /go/src/github.com/lf-edge/openbao/bin/bao /bin/bao": checking on sources under "/home/cipherboy/.local/share/containers/storage/overlay/7f7e7b301e82675b2bd2ea6b9dc496383f963b59484cca6cc5fac38b6c4018d6/merged": copier: stat: "/go/src/github.com/lf-edge/openbao/bin/bao": no such file or directory
make: *** [Makefile:61: docker-dev] Error 125
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kvendingoldo I'm happy to pick this one up for you, but I'd appreciate it if you could do the DCO that @naphelps mentioned so we can get this merged without it. :-)
@kvendingoldo Your commits need sign-offs using the |
ok, will fix it today |
Signed-off-by: Alexander Sharov <kvendingoldo@yandex.ru>
Signed-off-by: Alexander Sharov <kvendingoldo@yandex.ru>
Signed-off-by: Alexander Sharov <kvendingoldo@yandex.ru>
Signed-off-by: Alexander Sharov <kvendingoldo@yandex.ru>
Signed-off-by: Alexander Sharov <kvendingoldo@yandex.ru>
504b624
to
8e2610e
Compare
No description provided.