Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust issue template and PR template to fit OpenBao #5

Merged

Conversation

Scorpil
Copy link
Contributor

@Scorpil Scorpil commented Nov 29, 2023

Solves #3

Removing plugin submission template for now.
Added RFC template based on OpenTofu's with slight modifications.

Labels are configured based on #4

@jbutlerdev
Copy link
Contributor

Personally I like bao. It looks like opentofu uses tofu, so it would make sense to follow their lead

@Scorpil
Copy link
Contributor Author

Scorpil commented Nov 29, 2023

Agree @jbutlerdev. I don't believe there are any popular bao packages that could cause a clash on some systems, and being in sync with OpenTofu is a plus.

@naphelps
Copy link
Member

Make sure all commits use -s or --signoff for sign off.

Signed-off-by: Andrew Savchyn <dev@scorpil.com>
@Scorpil Scorpil force-pushed the issue-and-pr-tempalte-modifications branch from 359f48e to 0b1971e Compare November 30, 2023 16:30
- type: textarea
id: security
attributes:
label: Security Implications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think its worth highlighting everything in the RFC design, but perhaps adding user experience here would be a good catch-all bucket: e.g., developer experience integrating with this proposed change, operator experience trying to manage/configure it, ...

Just to make sure it gets thought about before dropping a (complex but useful) feature in...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, added ✅

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
…ction in RFC template

Signed-off-by: Andrew Savchyn <dev@scorpil.com>
@Scorpil Scorpil force-pushed the issue-and-pr-tempalte-modifications branch from eb8f9bb to 8ae7e24 Compare December 4, 2023 18:28
@Scorpil Scorpil marked this pull request as ready for review December 4, 2023 18:32
Copy link
Member

@naphelps naphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@naphelps naphelps merged commit d3f8023 into openbao:development Dec 6, 2023
1 check passed
@naphelps naphelps linked an issue Dec 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust issue template and PR template to fit OpenBao
5 participants