-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add stepwise to sdk #57
Merged
naphelps
merged 17 commits into
openbao:development
from
cipherboy:readd-stepwise-to-sdk
Jan 23, 2024
Merged
Re-add stepwise to sdk #57
naphelps
merged 17 commits into
openbao:development
from
cipherboy:readd-stepwise-to-sdk
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies
- docker brought in a broken containerd version v1.3.4 which resulted in an `undefined` error.
Update containerd to fix issue with docker libs
[COMPLIANCE] Update MPL-2.0 LICENSE
…f plugintypes. We have to use the branch version of the api for this for now, until that PR is merged, but we can't wait because we're blocking that PR without this change. (#4)
update dependencies
fix vault docker image
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Note that failing DCO relates to the existing commits from |
Note that this package is in the SDK so it remains importable by third-party plugins wishing to test against our instance. However, this allows it to be maintained alongside our distribution and is one fewer external dependency to maintain. Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
7efcdf5
to
d985f96
Compare
naphelps
approved these changes
Jan 23, 2024
naphelps
pushed a commit
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this package is in the SDK so it remains importable by third-party plugins wishing to test against our instance.
However, this allows it to be maintained alongside our distribution and is one fewer external dependency to maintain.
This was removed in 4b96eaf, though under a different path; this aligns more with the new
sdk/helper/testcluster
package naming that Nick added.Without this change (or, forking
vault-testing-stepwise
into our namespace), we get failures like: