Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add stepwise to sdk #57

Merged
merged 17 commits into from
Jan 23, 2024
Merged

Conversation

cipherboy
Copy link
Member

@cipherboy cipherboy commented Jan 23, 2024

Note that this package is in the SDK so it remains importable by third-party plugins wishing to test against our instance.

However, this allows it to be maintained alongside our distribution and is one fewer external dependency to maintain.

This was removed in 4b96eaf, though under a different path; this aligns more with the new sdk/helper/testcluster package naming that Nick added.


Without this change (or, forking vault-testing-stepwise into our namespace), we get failures like:

[cipherboy@lp10 openbao]$ go test github.com/openbao/openbao/builtin/credential/userpass
/home/cipherboy/GitHub/openbao/openbao
# github.com/openbao/openbao/builtin/credential/userpass [github.com/openbao/openbao/builtin/credential/userpass.test]
builtin/credential/userpass/stepwise_test.go:22:20: cannot use api.PluginTypeCredential (constant 1 of type "github.com/openbao/openbao/api".PluginType) as "github.com/hashicorp/vault/api".PluginType value in struct literal
builtin/credential/userpass/stepwise_test.go:61:11: cannot use func(resp *api.Secret, err error) error {…} (value of type func(resp *"github.com/openbao/openbao/api".Secret, err error) error) as stepwise.AssertionFunc value in struct literal
FAIL	github.com/openbao/openbao/builtin/credential/userpass [build failed]

jefferai and others added 15 commits July 12, 2021 18:56
- docker brought in a broken containerd version v1.3.4 which resulted in
  an `undefined` error.
Update containerd to fix issue with docker libs
[COMPLIANCE] Update MPL-2.0 LICENSE
…f plugintypes. We have to use the branch version of the api for this for now, until that PR is merged, but we can't wait because we're blocking that PR without this change. (#4)
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
@cipherboy
Copy link
Member Author

Note that failing DCO relates to the existing commits from vault-testing-stepwise and were copied verbatim here by git subtree add (and thus, have the same commit hashes). Adding artificial DCO to these would change the commit hashes.

@naphelps naphelps self-requested a review January 23, 2024 14:18
…6c67bcba2b6'

git-subtree-dir: sdk/helper/stepwise
git-subtree-mainline: 3bf3a57
git-subtree-split: 8abeba1
Note that this package is in the SDK so it remains importable by
third-party plugins wishing to test against our instance.

However, this allows it to be maintained alongside our distribution and
is one fewer external dependency to maintain.

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
@naphelps naphelps merged commit 04f1f22 into openbao:development Jan 23, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants