Remove Enos Test Scenarios #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
remove-enos-files
branch
from
aba33c3
to
5ef1a59
Compare
naphelps
approved these changes
Jan 30, 2024
naphelps
pushed a commit
that referenced
this pull request
Feb 2, 2024
* update gha workflows * update readme plugin register example * refactor out integration tests to fix broken workflow * add go version file * fix yaml syntax error * update acc test make target to use pkg dir * add workflow_dispatch for acc tests * fix yaml typo * update integration workflow * disable cgo for int build
naphelps
pushed a commit
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enos was a test harness runner built from scratch by a HashiCorp QE team. It intended to handle Enterprise test scenarios on a variety of configurations (Consul backends, HSMs, upgrades, ...) and was driven through a combination of Terraform and Bash. IIRC, it was rather slow and expensive to run. Likely we can get equivalent (if not better) coverage out of built-in Go unit tests using the container runner.
My suggestion proposed in this PR is to remove it, building what more testing we need directly in the test suite directly.