Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageDefinition or ContainerImage? #6

Closed
stain opened this issue Aug 12, 2019 · 3 comments
Closed

ImageDefinition or ContainerImage? #6

stain opened this issue Aug 12, 2019 · 3 comments

Comments

@stain
Copy link

stain commented Aug 12, 2019

The ImageDefinition example uses a type ImageDefinition which seems to be a rehash of ContainerImage

Should this be ImageDefinition or ContainerImage? The use of definition sounds odd given that it is about the container image - not it's definition/recipe! (Any schema.org metadata necessarily is a description). Also Image can be a photo, which would be misleading here.

@vsoch
Copy link
Member

vsoch commented Aug 12, 2019

Very good question! They are in fact essentially the same - the names / specifications went through a lot of discussion on the opencontainers list - and largely many had opinions and ImageDefinition was suggested. My preference was for ContainerImage (hence why it's still here) and for the exact reasons you mentioned, but ImageDefinition remained as an artifact of the previous discussion. I'll rename the example to match what (at least we agree) is a better direction.

@vsoch
Copy link
Member

vsoch commented Aug 12, 2019

And sidenote - asking people for suggestions on a list is a terrible way to get consensus... something something too many cooks. :)

@vsoch
Copy link
Member

vsoch commented Aug 12, 2019

okay, just updated #5

@vsoch vsoch closed this as completed Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants