FIX: Lead off command setting for v2 firmware and later

changelog.md

@@ -1,3 +1,9 @@
+# 1.0.4
+
+### Bug Fixes
+
+* Fixed lead off command sending for v2 firmware and later.
+
 # 1.0.3
 
 ### Bug Fixes

openBCICyton.js

@@ -1169,20 +1169,6 @@ Cyton.prototype.softReset = function () {
   return this.write(k.OBCIMiscSoftReset);
 };
 
-/**
- * @description To get the specified channelSettings register data from printRegisterSettings call
- * @param channelNumber - a number
- * @returns {Promise.<T>|*}
- * @author AJ Keller (@pushtheworldllc)
- */
-// TODO: REDO THIS FUNCTION
-Cyton.prototype.getSettingsForChannel = function (channelNumber) {
-  return k.channelSettingsKeyForChannel(channelNumber).then((newSearchingBuffer) => {
-    // this.searchingBuf = newSearchingBuffer
-    return this.printRegisterSettings();
-  });
-};
-
 /**
  * @description Syncs the internal channel settings object with a cyton, this will take about
  *  over a second because there are delays between the register reads in the firmware.
@@ -1335,7 +1321,14 @@ Cyton.prototype.impedanceTestContinuousStart = function () {
     for (let i = 0; i < this.numberOfChannels(); i++) {
       chain = chain
         .then(() => k.getImpedanceSetter(i + 1, false, true))
-        .then((commandsArray) => this.write(commandsArray));
+        .then((commandsArray) => {
+          if (this.usingAtLeastVersionTwoFirmware()) {
+            const buf = Buffer.from(commandsArray.join(''));
+            return this._writeAndDrain(buf);
+          } else {
+            return this.write(commandsArray);
+          }
+        });
     }
     chain.then(resolve, reject);
   });
@@ -1358,7 +1351,14 @@ Cyton.prototype.impedanceTestContinuousStop = function () {
     for (let i = 0; i < this.numberOfChannels(); i++) {
       chain = chain
         .then(() => k.getImpedanceSetter(i + 1, false, false))
-        .then((commandsArray) => this.write(commandsArray));
+        .then((commandsArray) => {
+          if (this.usingAtLeastVersionTwoFirmware()) {
+            const buf = Buffer.from(commandsArray.join(''));
+            return this._writeAndDrain(buf);
+          } else {
+            return this.write(commandsArray);
+          }
+        });
     }
     chain.then(resolve, reject);
   });
@@ -1567,7 +1567,12 @@ Cyton.prototype._impedanceTestSetChannel = function (channelNumber, pInput, nInp
     if (this.options.verbose) console.log('pInput: ' + pInput + ' nInput: ' + nInput);
     // Get impedance settings to send the board
     k.getImpedanceSetter(channelNumber, pInput, nInput).then((commandsArray) => {
-      return this.write(commandsArray);
+      if (this.usingAtLeastVersionTwoFirmware()) {
+        const buf = Buffer.from(commandsArray.join(''));
+        return this._writeAndDrain(buf);
+      } else {
+        return this.write(commandsArray);
+      }
     }).then(() => {
       /**
        * If either pInput or nInput are true then we should start calculating impedance. Setting

package.json

@@ -1,6 +1,6 @@
 {
   "name": "openbci-cyton",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "The official Node.js SDK for the OpenBCI Cyton with Dongle.",
   "main": "openBCICyton.js",
   "scripts": {
@@ -19,7 +19,7 @@
     "buffer-equal": "^1.0.0",
     "lodash": "^4.17.4",
     "mathjs": "^3.14.2",
-    "openbci-utilities": "^0.2.1",
+    "openbci-utilities": "^0.2.2",
     "safe-buffer": "^5.1.1",
     "serialport": "4.0.7",
     "sntp": "^2.0.2"
@@ -33,6 +33,11 @@
     "chai-as-promised": "^7.1.1",
     "codecov": "^2.1.0",
     "dirty-chai": "^2.0.1",
+    "eslint-config-semistandard": "^11.0.0",
+    "eslint-config-standard": "^10.2.1",
+    "eslint-plugin-promise": "^3.5.0",
+    "eslint-plugin-react": "^7.3.0",
+    "eslint-plugin-standard": "^3.0.1",
     "istanbul": "^0.4.4",
     "mocha": "^3.4.2",
     "sandboxed-module": "^2.0.3",