-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PREFIX / DESTDIR handled incorrectly in Makefiles #15
Comments
I notice that link isn't very clear on DESTDIR. $(PREFIX): this is the file name prefix you use in installed binaries/shell scripts/man pages/... |
Sorry that's my mistake - I thought that the DESTDIR change was enough for your use case. It seems that you already have a good understanding of the change you're looking for, so please raise a PR and I'll ensure it gets reviewed and merged ASAP. |
For this software, it is technically sufficient. It's more a matter of convenience -- adhering to DESTDIR / PREFIX distinction is convenient for package management things. I don't have git set-up currently, so here are is a manual 'patch':
by
and replace
by
|
The Makefiles use
$(DESTDIR)
where it should use$(DESTDIR)$(PREFIX)
instead. At least, that's the convention that is conventionally expected (*) (**):(^)
$(DESTDIR)$(PREFIX)
or$(DESTDIR)/$(PREFIX)
varies, but the latter seems safe in all cases (I gues?).(*) https://people.freebsd.org/~rodrigc/doc/data/doc/en_USa.ISO8859-1/books/porters-handbook/porting-prefix.html
(**) https://www.gnu.org/software/make/manual/html_node/DESTDIR.html
The text was updated successfully, but these errors were encountered: