Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue formulas of gene names with [-] (MT-ND1 + MT-CO1) do not plot #234

Closed
quiquemedina opened this issue Dec 10, 2021 · 7 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@quiquemedina
Copy link

December 10th, 2021

Greetings!

When querying with signatures (formulas containing gene names), if the gene names contain the separator “–”, example (MT-ND1 + MT-CO1), the APP does not provide plot outputs for signatures nor generate the corresponding data frames (blank output)
Notably, the individual genes plot fine, but their signatures (+, -, *. /, etc.) do not plot.

See the attachments for two examples.

Regards,

Issue formulas of gene names with [-] (MT-ND1 + MT-CO1) do not plot.pdf
Enrique

@ShixiangWang
Copy link
Member

Hi

Could you make sure you are using the latest version?And see if the problem still occur?

remotes::install_github("openbiox/UCSCXenaShiny")

@ShixiangWang
Copy link
Member

Also,please make sure set space between operators. We use space to detect if the user input a signature instead of a gene

@quiquemedina
Copy link
Author

quiquemedina commented Dec 12, 2021 via email

@ShixiangWang
Copy link
Member

@quiquemedina Thanks for your feedback. I will check ASAP and get back to you. :)

@ShixiangWang ShixiangWang added the bug Something isn't working label Dec 12, 2021
@ShixiangWang ShixiangWang self-assigned this Dec 12, 2021
@ShixiangWang
Copy link
Member

The issue is caused by the failed parse of the input expression:

The two genes are splitted into different part because it has - symbol.

> all.vars(parse(text = "MT-ND1 + MT-CO1"))
[1] "MT"  "ND1" "CO1"

In R, we have to use ` to avoid this.

> all.vars(parse(text = "`MT-ND1` + `MT-CO1`"))
[1] "MT-ND1" "MT-CO1"

So you should input using the second way.

Also you need to reinstall the package from GitHub again.

image

@ShixiangWang
Copy link
Member

A new version is released on CRAN. You can directly install the latest version from CRAN with install.packages soon.

@quiquemedina
Copy link
Author

quiquemedina commented Dec 13, 2021

I see. Querying for signatures as recommended above is now plotting just fine.

Thank you for the explanation.

Enrique

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants