Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurrent Error with Composed Gene Symbols in Gene Signatures using XenaShiny #283

Closed
quiquemedina opened this issue Dec 4, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@quiquemedina
Copy link

quiquemedina commented Dec 4, 2023

Uploading Gene signatures formatting recurrent running error with XenaShiny version updated.pdf…
Dear XenaShiny Developers,

I am writing to report a persistent issue we have encountered in the latest version of XenaShiny (UCSCXenaShiny v2.0.0 based on UCSCXenaTools v1.4.8). Specifically, we are facing difficulties when executing gene signatures that include gene symbols with complex names. For example, the following gene signature: (ADAMTS16 + AGBL3 + DGCR6 + EXD3 + MAGI2 + PLG + RASGRF1 + RB1 + SNORD116-1 + SNURF + SPATA31D1 + ZFAT-AS1 + ZNF833P) results in errors.
We observed that each composed gene symbol (e.g., SNORD116-1, ZFAT-AS1, SPATA31D1) functions correctly when run individually. However, when combined into a signature, whether formatted with or without backticks (gene_symbol), the process fails. For instance:

  • (SPATA31D1 + ZNF833P): failed
  • (SPATA31D1 + ZNF833P): failed
  • (ZFAT-AS1 + SNORD116-1 + SPATA31D1): failed

These errors occur despite the gene symbols running effectively in isolation (e.g., methylation vs TMB correlation analyses). The problem persists even when gene symbols are formatted as previously required by earlier versions of XenaShiny, for example: (ZFAT-AS1 + SNORD116-1 + SPATA31D1).

This issue is significantly impacting our analysis and we would greatly appreciate your assistance in resolving it.

Thank you for your attention to this matter.

Best regards,

Enrique
image

@ShixiangWang ShixiangWang self-assigned this Dec 5, 2023
@ShixiangWang ShixiangWang added the bug Something isn't working label Dec 5, 2023
@ShixiangWang
Copy link
Member

Hi @quiquemedina Thanks for the report. I will dig into this and fix it ASAP.

@ShixiangWang
Copy link
Member

@quiquemedina Hi, I pushed a commit to fix this issue.

The reason why gene signature did not work is that the SPATA31D1 has 1 sample less than other two genes, so it raised error when combining the data with unequal size.

@quiquemedina
Copy link
Author

Thank you for fixing the bug!

Tested ok with (CASP1 + CASP12 + CDK1 + DFNA5 + SPATA31D1 + MLKL + ZFAT-AS1 + SNORD116-1 + NLRP1 + NLRP3 + PABPC1 + PYCARD + RIPK3 + TNFAIP3 + TNFRSF1A)

@ShixiangWang
Copy link
Member

Good to hear that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants