-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPAddresses have field's value 0.0.0.0 #269
Comments
What should bmcweb do instead? Just leave the property off? |
From the description. |
Hi @edtanous, could I have a MR to update these fields to null? |
Feel free to push something to https://gerrit.openbmc.org/q/project:openbmc/bmcweb+status:open Be sure to follow our documentation https://github.com/openbmc/bmcweb/blob/master/DEVELOPING.md |
bmcweb set the default value of IPAddress/Gateway of Managers/bmc/EthernetInterfaces/<id> to "0.0.0.0" if these values are empty. The value display "0.0.0.0" is wrong and meaningless IP; this should be null. This updates these value to "null". Fixes: #269 Tested: Redfish-Usecase-Checkers passed. python3 manager_ethernet_interface/ \ manager_ethernet_interface_check.py -r ${BMC_IP}:443 -u root -p \ 0penBmc -S Always Found 1 manager instances Found 3 Ethernet interface instances in manager 'bmc' Testing interface 'eth0' Testing interface 'eth1' Testing interface 'usb0' Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com> Change-Id: I8278a8e14c39ce26ff393fbbd3b8993ea2c5e6a1
What is an MR? |
Hi @edtanous,
From this: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69864 |
What does "MR" mean? |
I mean a Gerrit review. |
bmcweb set the default value of IPAddress/Gateway of Managers/bmc/EthernetInterfaces/<id> to "0.0.0.0" if these values are empty. The value display "0.0.0.0" is wrong and meaningless IP; this should be null. This updates these value to "null". Fixes: #269 Tested: Redfish-Usecase-Checkers passed. python3 manager_ethernet_interface/ \ manager_ethernet_interface_check.py -r ${BMC_IP}:443 -u root -p \ 0penBmc -S Always Found 1 manager instances Found 3 Ethernet interface instances in manager 'bmc' Testing interface 'eth0' Testing interface 'eth1' Testing interface 'usb0' Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com> Change-Id: I8278a8e14c39ce26ff393fbbd3b8993ea2c5e6a1
bmcweb set the default value of IPAddress/Gateway of Managers/bmc/EthernetInterfaces/<id> to "0.0.0.0" if these values are empty. The value display "0.0.0.0" is wrong and meaningless IP; this should be null. This updates these value to "null". Fixes: #269 Tested: Redfish-Usecase-Checkers passed. python3 manager_ethernet_interface/ \ manager_ethernet_interface_check.py -r ${BMC_IP}:443 -u root -p \ 0penBmc -S Always Found 1 manager instances Found 3 Ethernet interface instances in manager 'bmc' Testing interface 'eth0' Testing interface 'eth1' Testing interface 'usb0' Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com> Change-Id: I8278a8e14c39ce26ff393fbbd3b8993ea2c5e6a1
bmcweb set the default value of IPAddress/Gateway of Managers/bmc/EthernetInterfaces/<id> to "0.0.0.0" if these values are empty. The value display "0.0.0.0" is wrong and meaningless IP; This should be null. This commit updates these values to null. Fixes: #269 Tested: Redfish-Usecase-Checkers passed. python3 manager_ethernet_interface/ \ manager_ethernet_interface_check.py -r ${BMC_IP}:443 -u root -p \ 0penBmc -S Always Found 1 manager instances Found 3 Ethernet interface instances in manager 'bmc' Testing interface 'eth0' Testing interface 'eth1' Testing interface 'usb0' Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com> Change-Id: I8278a8e14c39ce26ff393fbbd3b8993ea2c5e6a1
bmcweb set the default value of IPAddress/Gateway of Managers/bmc/EthernetInterfaces/<id> to "0.0.0.0" if these values are empty. The value display "0.0.0.0" is wrong and meaningless IP; This should be null. This commit updates these values to null. Fixes #269 Tested: Redfish-Usecase-Checkers passed. python3 manager_ethernet_interface/ \ manager_ethernet_interface_check.py -r ${BMC_IP}:443 -u root -p \ 0penBmc -S Always Found 1 manager instances Found 3 Ethernet interface instances in manager 'bmc' Testing interface 'eth0' Testing interface 'eth1' Testing interface 'usb0' Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com> Change-Id: I8278a8e14c39ce26ff393fbbd3b8993ea2c5e6a1
It looks like we may have been doing this correctly. I filed an issue with DMTF, and they are going to amend the wording to specifically call out the unconfigured case for ipv6 and ipv4 |
Closing, per discussion in DMTF, this behavior of using 0.0.0.0 for unset ipv4 addresses seems to be correct (even if not explicitly defined in the spec). Redfish usecase checker seems to be in the wrong here. Feel free to file a bug against it. |
Is this the right place to submit this?
Bug Description
Run Redfish GET
Expected result:
If there is no data setting for IP addresses/gateways, the value should be null.
Actual result:
Value display 0.0.0.0 is a wrong and meaningless IP
This make test of Redfish-Usecase-Compliance NetworkManager failed https://github.com/DMTF/Redfish-Usecase-Checkers
Version
Additional Information
bmcweb set the default Gateway to '0.0.0.0' is this value is empty https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/ethernet.hpp#L1660
The text was updated successfully, but these errors were encountered: