Increase size of buffer length variable #15
Conversation
| @@ -26,7 +26,7 @@ class ipmi_fru | |||
| std::string iv_name; | |||
|
|
|||
| // Length of a specific fru area. | |||
| size_t iv_len; | |||
| uint32_t iv_len; | |||
There was a problem hiding this comment.
I don't think you need to change these: size_t is not 8 bits; it's definitely big enough.
|
Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions. fru-area.H, line 29 [r1] (raw file):
I don't think you need to change these: size_t is absolutely big enough already. frup.c, line 951 [r1] (raw file):
Is there any reason not use use size_t here? Comments from Reviewable |
|
I was struggling to get reviewable to work so I commented on GitHub. Now I seem to have got Reviewable to work. Sorry for the duplication. |
|
The size of size_t is different in 32 and 64-bit architectures. There has been issues in the past in op-build where we had to change size_t to uint32_t to support compiling in 64-bit. So thought I'd make the change consistent and change the length to uint32_t.
|
|
That's a bit weird, but if we're using uint32_t elsewhere for sizes, I'm OK with doing it here.
|
The latest Barreleye vpd contains additional custom fields in one of the board sections, pushing the size of the buffer over 0x100. The current variable that stores the buffer size is set to be size_t, but the function using it crops it to uint8_t which doesn't fit the extended size. Changing the function to use size_t. Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. frup.c, line 951 [r2] (raw file):
Looks good. Comments from Reviewable |
The latest Barreleye vpd contains additional custom fields in one
of the board sections, pushing the size of the section to over 0x100.
The current variable that stores the buffer size is set to be
uint8_t which doesn't fit the extended size. Changing it to uint32_t.
Signed-off-by: Adriana Kobylak anoo@us.ibm.com
This change is