You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
*** Settings ***
Documentation This testsuite is for testing fan interface for openbmc
Suite Teardown Delete All Sessions
Resource ../lib/rest_client.robot
*** Test Cases ***
~
~
Shouldn't leave it empty with *** Test cases ****
[ ERROR ] Suite 'Test Fan' contains no tests.
tests/security/test_ssl.robot
Remove : Library RequestsLibrary.RequestsKeywords
The Library RequestsLibrary.RequestsKeywords is already include in the lib/rest_client.robot so no need to add redundant code here
tests/test_association.robot
Remove : Library BuiltIn
The built In doesn't need to be explicitly included
Probably a good idea if we could do this two combo in Test Suite Setup
This variable is not used anywhere in this suite, probably a copy paste left over code.
tests/test_eventlog.robot
Remove : Library BuiltIn
The built In doesn't need to be explicitly included
Typo : making NOT makeing in test case "makeing new log after obmc-phosphor-event.service restart"
Suggestion : Example, its good to verify the execute command to stop continue and fail latter if the command returns errors
${output}= Execute Command /sbin/reboot
To
${output} ${stderr}= Execute Command /sbin/reboot return_stderr=True
Should Be Empty ${stderr}
This would save time and error catching more better
Do for all the execute command in the code
The text was updated successfully, but these errors were encountered:
*** Settings ***
Documentation This testsuite is for testing fan interface for openbmc
Suite Teardown Delete All Sessions
Resource ../lib/rest_client.robot
*** Test Cases ***
~
~
Shouldn't leave it empty with *** Test cases ****
[ ERROR ] Suite 'Test Fan' contains no tests.
Remove : Library RequestsLibrary.RequestsKeywords
The Library RequestsLibrary.RequestsKeywords is already include in the lib/rest_client.robot so no need to add redundant code here
Remove : Library BuiltIn
The built In doesn't need to be explicitly included
Probably a good idea if we could do this two combo in Test Suite Setup
Clear all logs
Open Connection And Log In
Remove :
${SYSTEM_SHUTDOWN_TIME} ${5}
${WAIT_FOR_POWER_OPERATION} 30sec
This variable is not used anywhere in this suite, probably a copy paste left over code.
Remove : Library BuiltIn
The built In doesn't need to be explicitly included
Typo : making NOT makeing in test case "makeing new log after obmc-phosphor-event.service restart"
Suggestion : Example, its good to verify the execute command to stop continue and fail latter if the command returns errors
${output}= Execute Command /sbin/reboot
To
${output} ${stderr}= Execute Command /sbin/reboot return_stderr=True
Should Be Empty ${stderr}
This would save time and error catching more better
Do for all the execute command in the code
The text was updated successfully, but these errors were encountered: