PreTag Test Automation Basic Code clean-up needed

[gkeishin]

1. tests/test_fan.robot

*** Settings ***
Documentation This testsuite is for testing fan interface for openbmc
Suite Teardown Delete All Sessions
Resource ../lib/rest_client.robot

*** Test Cases ***
~

~

Shouldn't leave it empty with *** Test cases ****

[ ERROR ] Suite 'Test Fan' contains no tests.

1. tests/security/test_ssl.robot

Remove : Library RequestsLibrary.RequestsKeywords

The Library RequestsLibrary.RequestsKeywords is already include in the lib/rest_client.robot so no need to add redundant code here

1. tests/test_association.robot
   Remove : Library BuiltIn
   The built In doesn't need to be explicitly included

Probably a good idea if we could do this two combo in Test Suite Setup

Clear all logs
Open Connection And Log In

1. tests/test_bootpolicy.robot

Remove :
${SYSTEM_SHUTDOWN_TIME} ${5}
${WAIT_FOR_POWER_OPERATION} 30sec

This variable is not used anywhere in this suite, probably a copy paste left over code.

1. tests/test_eventlog.robot

Remove : Library BuiltIn
The built In doesn't need to be explicitly included

Typo : making NOT makeing in test case "makeing new log after obmc-phosphor-event.service restart"

Suggestion : Example, its good to verify the execute command to stop continue and fail latter if the command returns errors
${output}= Execute Command /sbin/reboot
To
${output} ${stderr}= Execute Command /sbin/reboot return_stderr=True
Should Be Empty ${stderr}

This would save time and error catching more better
Do for all the execute command in the code

[gkeishin]

Will fix this as well using this ticket.

PreTag test_power_restore.robot': Non-existing setting '[Documentation]' #8

[gkeishin]

Code pushed for review