Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port automation suite from the mkumatag personal repo without history #2

Closed
wants to merge 1 commit into from

Conversation

causten
Copy link
Member

@causten causten commented Jun 7, 2016

All these files came from https://github.com/mkumatag/openbmc-automation
The decision to remove the commit history was because most of the 122
commits did not follow commit comment AND content best practices.
The ability to remove the commit history was possible because all
contributors where from the same company (IBM) making the coordination /
notification/acceptence easy. See all the gory details about the
first try to commit with history here...
#1

This suite of tests will run against an OpenBMC based server. It will
run good/bad path testing against the REST interface. There are tests
that will also run ipmitool on the victim BMC too.

If you want to support a new system in to the suite you should only
have to edit two files...
data/.py
tox.ini

The README.md contains details on how to setup for the first time along
with how to execute the test suite


This change is Reviewable

@causten causten changed the title Port automation suite from the mkumatag personal repo with history Port automation suite from the mkumatag personal repo without history Jun 7, 2016
@anoo1
Copy link
Contributor

anoo1 commented Jun 13, 2016

hi @causten , reviewing with Patrick, please remove the binary tool ipmitool from this PR. All binaries should be built and not be part of the checked in code.

All these files came from https://github.com/mkumatag/openbmc-automation
The decision to remove the commit history was because most of the 122
commits did not follow commit comment AND content best practices.
The ability to remove the commit history was possible because all
contributors where from the same company (IBM) making the coordination /
notification/acceptence easy.  See all the gory details about the
first try to commit with history here...
openbmc#1

This suite of tests will run against an OpenBMC based server.  It will
run good/bad path testing against the REST interface.  There are tests
that will also run ipmitool on the victim BMC too.

If you want to support a new system in to the suite you should only
have to edit two files...
    data/<system>.py
    tox.ini

The README.md contains details on how to setup for the first time along
with how to execute the test suite

NOTE: some test cases require tools that do not exist on the system.
Currently the ipmitool is needed and if you do not manually copy / link
it in to the tools directory some suites will fail.
@mdmillerii
Copy link

I pointed out via chat the commit and title said with history instead of without history.
I see the pull request subject was fixed, unfortunately the subject title in commit subject was not fixed.

(I haven't yet done further review).

@mkumatag
Copy link

@anoo1 : The reason behind ipmitool binary kept in the code because we don't have that tool present in the openbmc. IMO building ipmitool is not a good idea, probably we can push that somewhere and copy it to part of tox script as prereq or include that into openbmc code itself so that tests can use without copying it.

@williamspatrick
Copy link
Member

Merged manually to master.

geissonator pushed a commit that referenced this pull request Sep 16, 2021
Change reporting tool to handle deprecated critical tag in updated v4.0+ robotframework.

- Patchset #1: initial commit.
- Patchset #2: change to total testcase count and Non-Critical test message.

Test:
- Change was tested with
Robot Framework 3.0.4 (Python 3.8.10 on linux)
Robot Framework 4.1.1 (Python 3.8.10 on linux)

Signed-off-by: Peter D  Phan <peterp@us.ibm.com>
Change-Id: I64a7f738c1ceaa8ac627854add4e2b1259de76df
geissonator pushed a commit that referenced this pull request Sep 30, 2021
Redfish Initiate Auto Reboot using busctl command.

- Patchset #1: Initial commit.
- Patchset #2: Change per review comments.

Change-Id: I943c5086f87d133ac4b47e3bf5ade7c5849053f2
Signed-off-by: Peter D  Phan <peterp@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants