Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User power cap boundary validation #1863

Closed
geissonator opened this issue Jun 27, 2017 · 4 comments
Closed

User power cap boundary validation #1863

geissonator opened this issue Jun 27, 2017 · 4 comments
Assignees

Comments

@geissonator
Copy link
Contributor

The user power cap has a lot of nuances. From the interface specification:

•	Prior to any communication with the OCC, the BMC will have a default min/max power limit from the configuration file that must cover all power configuration settings.
•	On the first poll with the OCC the BMC must update the min/max power limit that the master OCC provides in the “CAPS” sensor section of poll response.  In addition, in the case that the current power limit set is now out of bounds from the new min/max power limit being reported from the OCC the BMC must clip the current power limit to be min or max.

#1771 is the story for the new settingsd code to verify limits. The ideal solution here is for us to write a scrip that parses the MRW for these 2 values and puts them in as the defaults for the user power cap.

<attribute>
	<id>OPEN_POWER_N_PLUS_ONE_BULK_POWER_LIMIT_WATTS</id>
	<default>2375</default>
</attribute>
<attribute>
	<id>OPEN_POWER_SOFT_MIN_PCAP_WATTS</id>
	<default>1945</default>
</attribute>

It's not clear to me if these are good enough or if we still need to look at the OCC poll response and dynamically adjust these based on that. That will need to be determined in this story.

@williamspatrick
Copy link
Member

Are you suggesting we would need to dynamically alter the limits we allow a user to put in place? That sounds excessive.

@geissonator
Copy link
Contributor Author

Yes, in the past, code would do an inventory of the system (number of dimms, cores, io) and dynamically calculate what the power min/max boundaries should be. Not clear to me if that's happening on our OP systems though.

@gtmills
Copy link
Member

gtmills commented Sep 19, 2017

@rfrandse rfrandse assigned gtmills and unassigned spinler Sep 25, 2017
@rfrandse
Copy link

rfrandse commented Oct 5, 2017

https://gerrit.openbmc-project.xyz/7079 Add power cap boundary validation
Resolves #1863 User power cap boundary validation

bradbishop pushed a commit to openbmc/meta-openpower that referenced this issue Jan 13, 2018
Limit the power cap boundaries based on values from the MRW.
Use OPEN_POWER_N_PLUS_ONE_BULK_POWER_LIMIT_WATTS and
OPEN_POWER_SOFT_MIN_PCAP_WATTS from the MRW for the boundaries.

Resolves openbmc/openbmc#1863

Change-Id: I16ff55dc8dab8a0f8b837e815e9e409ad23db644
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
bradbishop pushed a commit to openbmc/meta-ibm that referenced this issue Aug 22, 2018
Limit the power cap boundaries based on values from the MRW.
Use OPEN_POWER_N_PLUS_ONE_BULK_POWER_LIMIT_WATTS and
OPEN_POWER_SOFT_MIN_PCAP_WATTS from the MRW for the boundaries.

Resolves openbmc/openbmc#1863

Change-Id: I16ff55dc8dab8a0f8b837e815e9e409ad23db644
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants