-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User power cap boundary validation #1863
Comments
Are you suggesting we would need to dynamically alter the limits we allow a user to put in place? That sounds excessive. |
Yes, in the past, code would do an inventory of the system (number of dimms, cores, io) and dynamically calculate what the power min/max boundaries should be. Not clear to me if that's happening on our OP systems though. |
|
https://gerrit.openbmc-project.xyz/7079 Add power cap boundary validation |
Limit the power cap boundaries based on values from the MRW. Use OPEN_POWER_N_PLUS_ONE_BULK_POWER_LIMIT_WATTS and OPEN_POWER_SOFT_MIN_PCAP_WATTS from the MRW for the boundaries. Resolves openbmc/openbmc#1863 Change-Id: I16ff55dc8dab8a0f8b837e815e9e409ad23db644 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Limit the power cap boundaries based on values from the MRW. Use OPEN_POWER_N_PLUS_ONE_BULK_POWER_LIMIT_WATTS and OPEN_POWER_SOFT_MIN_PCAP_WATTS from the MRW for the boundaries. Resolves openbmc/openbmc#1863 Change-Id: I16ff55dc8dab8a0f8b837e815e9e409ad23db644 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
The user power cap has a lot of nuances. From the interface specification:
#1771 is the story for the new settingsd code to verify limits. The ideal solution here is for us to write a scrip that parses the MRW for these 2 values and puts them in as the defaults for the user power cap.
It's not clear to me if these are good enough or if we still need to look at the OCC poll response and dynamically adjust these based on that. That will need to be determined in this story.
The text was updated successfully, but these errors were encountered: