Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMC: Enable patching #2149

Closed
anoo1 opened this issue Aug 14, 2017 · 1 comment
Closed

BMC: Enable patching #2149

anoo1 opened this issue Aug 14, 2017 · 1 comment
Assignees

Comments

@anoo1
Copy link
Contributor

anoo1 commented Aug 14, 2017

The BMC filesystem is read-only in the ubi implementation. Need a way to patch BMC binaries by using the /usr/local path.

@anoo1 anoo1 added the Phase 5 label Aug 14, 2017
@anoo1 anoo1 added this to the openBMC v2.0 Backlog milestone Aug 14, 2017
@rfrandse
Copy link

https://gerrit.openbmc-project.xyz/6009 Enable BMC patching from the /usr/local path
Resolves #2149 BMC: Enable patching

williamspatrick pushed a commit that referenced this issue Aug 28, 2017
This commit fixes an error introduced by #2149 in
which phosphor-gpio-monitor@checkstop.service would fail because
the file /etc/default/obmc/gpio/checkstop defines PATH and not
DEVPATH. PATH is, of course, an environment variable that should
not be changed.

The problem is fixed by updating the defintion in this file from
PATH to DEVPATH.

Resolves #2216

Change-Id: I941c0c1315e49abd21daceb5b9f9e7719b5cb0bf
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>
bradbishop pushed a commit to openbmc/meta-phosphor that referenced this issue Jan 13, 2018
This commit enables patches from the /usr/local path by replacing
absolute paths to /usr/sbin or /usr/bin in every service file with
"/usr/bin/env ". Additionally, SyslogIdentifier is added to each
file to ensure that journal entries are still distinct.

In two cases, service files also had to change due to references
to ${{PATH}}, which doesn't work with /usr/bin/env. These
references - and the corresponding definitions - were changed to
${{DEVPATH}}.

Resolves openbmc/openbmc#2149

Change-Id: I12c5c6e5101eef6820b985a563313836250ff2c7
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>
bradbishop pushed a commit to openbmc/meta-openpower that referenced this issue Jan 13, 2018
This commit enables patches from the /usr/local path by replacing
absolute paths to /usr/sbin or /usr/bin in every service file with
"/usr/bin/env ". Additionally, SyslogIdentifier is added to each
file to ensure that journal entries are still distinct.

In two cases, service files also had to change due to references
to ${{PATH}}, which doesn't work with /usr/bin/env. These
references - and the corresponding definitions - were changed to
${{DEVPATH}}.

Resolves openbmc/openbmc#2149

Change-Id: I12c5c6e5101eef6820b985a563313836250ff2c7
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>
bradbishop pushed a commit to openbmc/meta-openpower that referenced this issue Jan 13, 2018
This commit fixes an error introduced by openbmc/openbmc#2149 in
which phosphor-gpio-monitor@checkstop.service would fail because
the file /etc/default/obmc/gpio/checkstop defines PATH and not
DEVPATH. PATH is, of course, an environment variable that should
not be changed.

The problem is fixed by updating the defintion in this file from
PATH to DEVPATH.

Resolves openbmc/openbmc#2216

Change-Id: I941c0c1315e49abd21daceb5b9f9e7719b5cb0bf
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>
bradbishop pushed a commit to openbmc/meta-ingrasys that referenced this issue Aug 22, 2018
This commit enables patches from the /usr/local path by replacing
absolute paths to /usr/sbin or /usr/bin in every service file with
"/usr/bin/env ". Additionally, SyslogIdentifier is added to each
file to ensure that journal entries are still distinct.

In two cases, service files also had to change due to references
to ${{PATH}}, which doesn't work with /usr/bin/env. These
references - and the corresponding definitions - were changed to
${{DEVPATH}}.

Resolves openbmc/openbmc#2149

Change-Id: I12c5c6e5101eef6820b985a563313836250ff2c7
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>
bradbishop pushed a commit to openbmc/meta-quanta that referenced this issue Aug 22, 2018
This commit enables patches from the /usr/local path by replacing
absolute paths to /usr/sbin or /usr/bin in every service file with
"/usr/bin/env ". Additionally, SyslogIdentifier is added to each
file to ensure that journal entries are still distinct.

In two cases, service files also had to change due to references
to ${{PATH}}, which doesn't work with /usr/bin/env. These
references - and the corresponding definitions - were changed to
${{DEVPATH}}.

Resolves openbmc/openbmc#2149

Change-Id: I12c5c6e5101eef6820b985a563313836250ff2c7
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>
bradbishop pushed a commit to openbmc/meta-ibm that referenced this issue Aug 22, 2018
This commit enables patches from the /usr/local path by replacing
absolute paths to /usr/sbin or /usr/bin in every service file with
"/usr/bin/env ". Additionally, SyslogIdentifier is added to each
file to ensure that journal entries are still distinct.

In two cases, service files also had to change due to references
to ${{PATH}}, which doesn't work with /usr/bin/env. These
references - and the corresponding definitions - were changed to
${{DEVPATH}}.

Resolves openbmc/openbmc#2149

Change-Id: I12c5c6e5101eef6820b985a563313836250ff2c7
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>
bradbishop pushed a commit to openbmc/meta-x86 that referenced this issue Aug 23, 2018
This commit enables patches from the /usr/local path by replacing
absolute paths to /usr/sbin or /usr/bin in every service file with
"/usr/bin/env ". Additionally, SyslogIdentifier is added to each
file to ensure that journal entries are still distinct.

In two cases, service files also had to change due to references
to ${{PATH}}, which doesn't work with /usr/bin/env. These
references - and the corresponding definitions - were changed to
${{DEVPATH}}.

Resolves openbmc/openbmc#2149

Change-Id: I12c5c6e5101eef6820b985a563313836250ff2c7
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants